London | 26-ITP-Jan | Divine Mankrado | Sprint 3 | Practice TDD by divinmank · Pull Request #1239 · CodeYourFuture/Module-Structuring-and-Testing-Data

divinmank · 2026-03-10T15:51:22Z

Learners, PR Template

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Finished the practice TDD segment of sprint 3.

cjyuan

Function implementation is correct.
A few tests could use some improvement.

cjyuan · 2026-03-14T15:21:02Z

Sprint-3/2-practice-tdd/count.test.js

+test("should return 0 if the character does not exist in the string", () => {
+  const str = "hello";
+  const char = "z";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});
+
+test("should return 0 if the character does not exist in the string", () => {
+  const str = "hello";
+  const char = "z";
+  const count = countChar(str, char);
+  expect(count).toEqual(0);
+});


Duplicated.

cjyuan · 2026-03-14T15:23:04Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

+// Case 4: Numbers ending with 11, 12, 13, or any other digit
+// When the number ends with 11, 12, 13, or any digit not 1, 2, or 3,
+// Then the function should return a string by appending "th" to the number.
+test("should append 'th' for numbers ending with 11, 12, 13, or other digits", () => {


When a test fails with the message "... or other digits", it may be unclear what "other digits" actually refers to.
Can you revise the test description to make it more informative?

cjyuan · 2026-03-14T15:25:25Z

Sprint-3/2-practice-tdd/count.test.js

Could consider testing a few more samples in this script - higher chance to detect bugs in code.

The original specification did not clearly state whether the character match should be case-sensitive.
Most people would probably assume that it is, but to demonstrate our understanding or clarify the assumption we made,
we could add test cases to convey this. For examples,

A case to show that the match is case sensitive

A case to show that the function is expected to work also for non-alphabets

divinmank · 2026-03-19T15:02:53Z

Thanks for the feedback!

Removed the duplicated test in count.test.js
Improved the test description for ordinal numbers to make it clearer
Added additional test cases for case sensitivity, non-alphabet characters, and more sample inputs
Let me know if there’s anything else I can improve

…/divinmank/Module-Structuring-and-Testing-Data into coursework/sprint-3-practice-tdd

cjyuan

Other changes look good. I will mark this PR as complete first.

You should also add the "Needs Review" label when your PR is ready to be re-reviewed.

cjyuan · 2026-03-23T03:14:35Z

Sprint-3/2-practice-tdd/get-ordinal-number.test.js

+test("should append 'th' for numbers ending with 11, 12, or 13", () => {
+  expect(getOrdinalNumber(11)).toEqual("11th");
+  expect(getOrdinalNumber(12)).toEqual("12th");
+  expect(getOrdinalNumber(13)).toEqual("13th");
+  expect(getOrdinalNumber(4)).toEqual("4th");


Description is still not quite accurate. Numbers like 4 and 10 does not end with 11, 12, or 13.

github-actions · 2026-03-23T03:17:16Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/2-practice-tdd/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-03-23T03:17:17Z

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Sprint-3/2-practice-tdd/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

cjyuan · 2026-03-23T03:21:02Z

Sprint-1/Module-Structuring-and-Testing-Data

Can you remove this file to keep the branch clean?

divinmank added 4 commits March 6, 2026 18:06

Finished practice tdd count

670ac51

Finished count test

844e904

Finished get ordinal numberFinished get-ordinal number and the test

94b050b

Finished repeat

7b24b31

divinmank added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 10, 2026

This comment has been minimized.

Sign in to view

github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 10, 2026

divinmank added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Mar 10, 2026

Merge branch 'main' into coursework/sprint-3-practice-tdd

8784dec

cjyuan reviewed Mar 14, 2026

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Mar 14, 2026

divinmank added 2 commits March 20, 2026 14:47

Updated

23f5712

Merge branch 'coursework/sprint-3-practice-tdd' of https://github.com…

8710bf3

…/divinmank/Module-Structuring-and-Testing-Data into coursework/sprint-3-practice-tdd

divinmank mentioned this pull request Mar 22, 2026

26-ITP-JAN | Structuring and Testing Data | Divine Mankrado divinmank/My-Coursework-Planner#28

Open

cjyuan reviewed Mar 23, 2026

View reviewed changes

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Mar 23, 2026

cjyuan reviewed Mar 23, 2026

View reviewed changes

Sprint-1/Module-Structuring-and-Testing-Data

Copy link

Contributor

cjyuan Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove this file to keep the branch clean?

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

London | 26-ITP-Jan | Divine Mankrado | Sprint 3 | Practice TDD#1239

London | 26-ITP-Jan | Divine Mankrado | Sprint 3 | Practice TDD#1239
divinmank wants to merge 7 commits intoCodeYourFuture:mainfrom
divinmank:coursework/sprint-3-practice-tdd

divinmank commented Mar 10, 2026 •

edited

Loading

Uh oh!

This comment has been minimized.

cjyuan left a comment

Uh oh!

cjyuan Mar 14, 2026

Uh oh!

cjyuan Mar 14, 2026

Uh oh!

cjyuan Mar 14, 2026

Uh oh!

divinmank commented Mar 19, 2026

Uh oh!

cjyuan left a comment

Uh oh!

cjyuan Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

cjyuan Mar 23, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

divinmank commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Learners, PR Template

Changelist

Uh oh!

This comment has been minimized.

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 14, 2026

Choose a reason for hiding this comment

Uh oh!

divinmank commented Mar 19, 2026

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

github-actions bot commented Mar 23, 2026

Uh oh!

cjyuan Mar 23, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

divinmank commented Mar 10, 2026 •

edited

Loading